From ad4847e1c5fa3a1c0974dd77112e54a50f6100ba Mon Sep 17 00:00:00 2001
From: Hyko <punk.flag8609@fastmail.com>
Date: Wed, 22 Apr 2026 20:41:35 -0400
Subject: [PATCH] fix(auth): hide error/success messages when user is
 authenticated or conflicting states exist

---
 src/features/auth/pages/ForgotPasswordPage.client.js | 4 ++--
 src/features/auth/pages/LoginPage.client.js          | 4 ++--
 src/features/auth/pages/LogoutPage.client.js         | 2 +-
 src/features/auth/pages/RegisterPage.client.js       | 4 ++--
 src/features/auth/pages/ResetPasswordPage.client.js  | 2 +-
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/features/auth/pages/ForgotPasswordPage.client.js b/src/features/auth/pages/ForgotPasswordPage.client.js
index afe7126..1f7a39d 100644
--- a/src/features/auth/pages/ForgotPasswordPage.client.js
+++ b/src/features/auth/pages/ForgotPasswordPage.client.js
@@ -68,7 +68,7 @@ export default function ForgotPasswordPage({ onSubmit, onNavigate, currentUser =
         </div>
       )}
 
-      {error && (
+      {error && !currentUser && !success && (
         <div className="mb-4 p-3 bg-red-50 border border-red-200 rounded-lg dark:bg-red-500/10 dark:border-red-500/20">
           <div className="flex items-center space-x-2">
             <div className="w-1.5 h-1.5 bg-red-500 rounded-full flex-shrink-0"></div>
@@ -77,7 +77,7 @@ export default function ForgotPasswordPage({ onSubmit, onNavigate, currentUser =
         </div>
       )}
 
-      {success && (
+      {success && !currentUser && (
         <div className="mb-4 p-3 bg-green-50 border border-green-200 rounded-lg dark:bg-green-500/10 dark:border-green-500/20">
           <div className="flex items-center space-x-2">
             <div className="w-1.5 h-1.5 bg-green-500 rounded-full flex-shrink-0"></div>
diff --git a/src/features/auth/pages/LoginPage.client.js b/src/features/auth/pages/LoginPage.client.js
index 6e4fef3..8369b62 100644
--- a/src/features/auth/pages/LoginPage.client.js
+++ b/src/features/auth/pages/LoginPage.client.js
@@ -85,7 +85,7 @@ export default function LoginPage({ onSubmit, onNavigate, onSetSessionCookie, re
         </div>
       )}
 
-      {success && (
+      {success && !currentUser && (
         <div className="mb-4 p-3 bg-green-50 border border-green-200 rounded-lg dark:bg-green-500/10 dark:border-green-500/20">
           <div className="flex items-center space-x-2">
             <div className="w-1.5 h-1.5 bg-green-500 rounded-full flex-shrink-0"></div>
@@ -94,7 +94,7 @@ export default function LoginPage({ onSubmit, onNavigate, onSetSessionCookie, re
         </div>
       )}
 
-      {error && (
+      {error && !currentUser && !success && (
         <div className="mb-4 p-3 bg-red-50 border border-red-200 rounded-lg dark:bg-red-500/10 dark:border-red-500/20">
           <div className="flex items-center space-x-2">
             <div className="w-1.5 h-1.5 bg-red-500 rounded-full flex-shrink-0"></div>
diff --git a/src/features/auth/pages/LogoutPage.client.js b/src/features/auth/pages/LogoutPage.client.js
index 59f7c56..4a36efe 100644
--- a/src/features/auth/pages/LogoutPage.client.js
+++ b/src/features/auth/pages/LogoutPage.client.js
@@ -60,7 +60,7 @@ export default function LogoutPage({ onLogout, onSetSessionCookie }) {
         </div>
       )}
 
-      {error && (
+      {error && !success && (
         <div className="mb-4 p-3 bg-red-50 border border-red-200 rounded-lg dark:bg-red-500/10 dark:border-red-500/20">
           <div className="flex items-center space-x-2">
             <div className="w-1.5 h-1.5 bg-red-500 rounded-full flex-shrink-0"></div>
diff --git a/src/features/auth/pages/RegisterPage.client.js b/src/features/auth/pages/RegisterPage.client.js
index 878301c..6da7dbb 100644
--- a/src/features/auth/pages/RegisterPage.client.js
+++ b/src/features/auth/pages/RegisterPage.client.js
@@ -120,7 +120,7 @@ export default function RegisterPage({ onSubmit, onNavigate, currentUser = null
         </div>
       )}
 
-      {error && (
+      {error && !currentUser && !success && (
         <div className="mb-4 p-3 bg-red-50 border border-red-200 rounded-lg dark:bg-red-500/10 dark:border-red-500/20">
           <div className="flex items-center space-x-2">
             <div className="w-1.5 h-1.5 bg-red-500 rounded-full flex-shrink-0"></div>
@@ -129,7 +129,7 @@ export default function RegisterPage({ onSubmit, onNavigate, currentUser = null
         </div>
       )}
 
-      {success && (
+      {success && !currentUser && (
         <div className="mb-4 p-3 bg-green-50 border border-green-200 rounded-lg dark:bg-green-500/10 dark:border-green-500/20">
           <div className="flex items-center space-x-2">
             <div className="w-1.5 h-1.5 bg-green-500 rounded-full flex-shrink-0"></div>
diff --git a/src/features/auth/pages/ResetPasswordPage.client.js b/src/features/auth/pages/ResetPasswordPage.client.js
index fcc7545..9ee80ff 100644
--- a/src/features/auth/pages/ResetPasswordPage.client.js
+++ b/src/features/auth/pages/ResetPasswordPage.client.js
@@ -74,7 +74,7 @@ export default function ResetPasswordPage({ onSubmit, onNavigate, email, token }
         </p>
       </div>
 
-      {error && (
+      {error && !success && (
         <div className="mb-4 p-3 bg-red-50 border border-red-200 rounded-lg dark:bg-red-500/10 dark:border-red-500/20">
           <div className="flex items-center space-x-2">
             <div className="w-1.5 h-1.5 bg-red-500 rounded-full flex-shrink-0"></div>