From 0dc609278028d3b9b72c4eb5375628cf837e9520 Mon Sep 17 00:00:00 2001
From: Hyko <punk.flag8609@fastmail.com>
Date: Wed, 22 Apr 2026 19:41:57 -0400
Subject: [PATCH] refactor(ui): change Button icon prop to accept component
 reference instead of JSX element

---
 src/features/admin/pages/UsersPage.client.js |  2 +-
 src/shared/components/Button.js              | 10 ++++++----
 src/shared/components/Modal.js               |  2 +-
 3 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/src/features/admin/pages/UsersPage.client.js b/src/features/admin/pages/UsersPage.client.js
index 6d0d925..f2aa630 100644
--- a/src/features/admin/pages/UsersPage.client.js
+++ b/src/features/admin/pages/UsersPage.client.js
@@ -80,7 +80,7 @@ const UsersPageClient = () => {
                     variant="secondary"
                     size="sm"
                     onClick={() => setEditingUserId(user.id)}
-                    icon={<PencilEdit01Icon className="w-4 h-4" />}
+                    icon={PencilEdit01Icon}
                 >
                     Modifier
                 </Button>
diff --git a/src/shared/components/Button.js b/src/shared/components/Button.js
index 99f98a4..a3a7ed5 100644
--- a/src/shared/components/Button.js
+++ b/src/shared/components/Button.js
@@ -56,6 +56,8 @@ const Button = ({
         }
     };
 
+    const Icon = icon;
+
     return (
         <button
             type={type}
@@ -68,12 +70,12 @@ const Button = ({
                 <LoadingSpinner />
             ) : (
                 <>
-                    {icon && iconPosition === 'left' && (
-                        <span className={iconSizes[size]}>{icon}</span>
+                    {Icon && iconPosition === 'left' && (
+                        <span className={iconSizes[size]}><Icon /></span>
                     )}
                     {children}
-                    {icon && iconPosition === 'right' && (
-                        <span className={iconSizes[size]}>{icon}</span>
+                    {Icon && iconPosition === 'right' && (
+                        <span className={iconSizes[size]}><Icon /></span>
                     )}
                 </>
             )}
diff --git a/src/shared/components/Modal.js b/src/shared/components/Modal.js
index 7ded6cb..79e4525 100644
--- a/src/shared/components/Modal.js
+++ b/src/shared/components/Modal.js
@@ -92,7 +92,7 @@ const Modal = ({
                                 variant="ghost"
                                 size="sm"
                                 onClick={onClose}
-                                icon={<Cancel01Icon className="w-4 h-4" />}
+                                icon={Cancel01Icon}
                                 className="!p-1 -mr-1"
                             />
                         )}